[v16] Refactor CLI prompt and config logic#47925
Merged
Joerger merged 2 commits intobranch/v16from Oct 25, 2024
Merged
Conversation
* Refactor CLI prompt and config logic. * Move CLI prompt configuration to CLIPrompt * Factor out dual prompt in CLI prompt logic. * Make cli config a field rather than embedded; Add NewCLIPromptV2.
Joerger
added
the
no-changelog
bernardjkim
approved these changes
Oct 25, 2024
codingllama
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #47874 to branch/v16